Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 313t test #217

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

andife
Copy link
Contributor

@andife andife commented Mar 9, 2025

No description provided.

@takluyver
Copy link
Member

As things stand, the tests are failing to install some dependencies of Jupyter:

jupyter-server/jupyter_server#1473

It might be possible to work around that by testing without nbdime and skipping the relevant tests. But I don't know if there's much value in nbval supporting free-threading Python if you can't run Jupyter with it yet.

@andife
Copy link
Contributor Author

andife commented Mar 30, 2025

As things stand, the tests are failing to install some dependencies of Jupyter:

jupyter-server/jupyter_server#1473

It might be possible to work around that by testing without nbdime and skipping the relevant tests. But I don't know if there's much value in nbval supporting free-threading Python if you can't run Jupyter with it yet.

You're right, nbval probably doesn't have the big effect of being free-threading compatible, I think nbval should already fit, the test currently rather checks the dependencies of nbval .

I think currently free threading is probably not yet the big win for many packages per se? (I don't know, at the moment you still have to fight with individual dependencies and that there are no environment markers). For us (onnx) nbval is a dependency for testing in the CI process. Therefore, I try to look at the dependencies to see if small changes could help, e.g. by cleaning up the dependencies #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants