test for bug: TeeStream cannot handle high output (ie cat thousand_lines) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
May 6, 2024
| @@ -0,0 +1,10 @@ | |||
| 0 | |||
There was a problem hiding this comment.
FWIW -- please do not populate such simple to generate files within repo. If needed -- a fixture with a session scope could create such files to be re-used across tests.
…inary stream mode
|
Closing in favor of #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at e2e testing of the TeeStream class.
Currently not passing when using cat with more than 10^3 lines
Theres a couple problems. [minor] First, it isn't deterministic on how much is written at a time, ie 250 lines one call, 300 the next, so asserting has_calls isn't working.
Bigger problem: somewhere between cat 100lines and cat 1000lines, TeeStream fails to print the whole thing before closing.