Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm num_samples & num_reports from summary_format #200

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Oct 9, 2024

These variables are still available for users who provide a custom summary_format

Fixes #188

@asmacdo asmacdo added the semver-minor Increment the minor version when merged label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.00%. Comparing base (aac696f) to head (a34a063).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files           2        2           
  Lines         567      567           
  Branches       65       65           
=======================================
  Hits          533      533           
  Misses         22       22           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

These variables are still available for users who provide a custom
summary_format

Fixes con#188
@asmacdo asmacdo force-pushed the simplify-summary-out branch from daf7505 to 00c2925 Compare October 23, 2024 20:05
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./.update-readme-help.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@asmacdo asmacdo force-pushed the simplify-summary-out branch from 00c2925 to a34a063 Compare October 23, 2024 20:07
@asmacdo asmacdo added the release Create a release when this pr is merged label Oct 23, 2024
@asmacdo
Copy link
Member Author

asmacdo commented Oct 23, 2024

@yarikoptic Its been a bit since last release. Lets go ahead and cut one. Ready for review and merge if you like.

@yarikoptic yarikoptic merged commit 62308cb into con:main Oct 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove num_samples and num_reports from default summary_format
2 participants