-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing for Python 3.13 #202
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 94.05% 94.05%
=======================================
Files 2 2
Lines 572 572
Branches 66 66
=======================================
Hits 538 538
Misses 22 22
Partials 12 12 ☔ View full report in Codecov by Sentry. |
test/test_execution.py
Outdated
@@ -213,7 +213,7 @@ def runner() -> int: | |||
|
|||
thread = threading.Thread(target=runner) | |||
thread.start() | |||
sleep(0.03) # make sure the process is started | |||
sleep(0.1) # make sure the process is started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously this error was caused by not waiting log enough. but now im skeptical (it could be another reason ps is returning a nonzero)
if check and retcode:
> raise CalledProcessError(retcode, process.args,
output=stdout, stderr=stderr)
E subprocess.CalledProcessError: Command 'ps aux | grep '[s]leep 60.74016230000801'' returned non-zero exit status 1.
/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/subprocess.py:577: CalledProcessError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was stderr while running it?
is there shell=True
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please try tmate action so you could login into github action environment, and try it
"first hand"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes shell=True
With tmate
action I was able to ssh into the action machine.
- name: Setup tmate session
uses: mxschmitt/action-tmate@v3
But ... tox -e py -- -vv --cov-report=xml
passed?! I'm not sure what I'm missing here, but this is confusing!
864d993
to
b48e0c7
Compare
lets wait a whole second just to see what happens
Weird that this only happens on python3.13 though
since also desired for conda IIRC, let's merge/release. So merge whenever satisfied (I see some TMP, not sure if still in the queue) |
Fixes #157