Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for Python 3.13 #202

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Add testing for Python 3.13 #202

merged 8 commits into from
Oct 24, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Oct 9, 2024

Fixes #157

@asmacdo asmacdo added the semver-minor Increment the minor version when merged label Oct 9, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.05%. Comparing base (484e0e5) to head (320f0af).
Report is 35 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files           2        2           
  Lines         572      572           
  Branches       66       66           
=======================================
  Hits          538      538           
  Misses         22       22           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -213,7 +213,7 @@ def runner() -> int:

thread = threading.Thread(target=runner)
thread.start()
sleep(0.03) # make sure the process is started
sleep(0.1) # make sure the process is started
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously this error was caused by not waiting log enough. but now im skeptical (it could be another reason ps is returning a nonzero)

             if check and retcode:
>               raise CalledProcessError(retcode, process.args,
                                         output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command 'ps aux | grep '[s]leep 60.74016230000801'' returned non-zero exit status 1.
/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/subprocess.py:577: CalledProcessError

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was stderr while running it?

is there shell=True?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please try tmate action so you could login into github action environment, and try it
"first hand"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes shell=True

With tmate action I was able to ssh into the action machine.

      - name: Setup tmate session
        uses: mxschmitt/action-tmate@v3

But ... tox -e py -- -vv --cov-report=xml passed?! I'm not sure what I'm missing here, but this is confusing!

Weird that this only happens on python3.13 though
@yarikoptic
Copy link
Member

since also desired for conda IIRC, let's merge/release. So merge whenever satisfied (I see some TMP, not sure if still in the queue)

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Oct 24, 2024
@asmacdo asmacdo merged commit c9ff794 into con:main Oct 24, 2024
14 checks passed
@asmacdo asmacdo deleted the add-3.13 branch October 24, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Python 3.13 starting October 1 2024
2 participants