-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extra patches path #17520
Open
memsharded
wants to merge
20
commits into
conan-io:develop2
Choose a base branch
from
memsharded:feature/extra_patche_path
base: develop2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+123
−26
Open
extra patches path #17520
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1cefc59
extra patches path
memsharded c326b8b
Update conan/tools/files/patches.py
memsharded 27ba2a3
fix docstring of Environment.vars() (#17521)
kambala-decapitator 31d1aca
GnuToolchain's make_args handle empty values correctly (#17532)
ErniGH b406b3d
Change replace_in_file to return True on success (#17531)
mrbean-bremen 6e4f466
upgrade bottle version (#17534)
memsharded ca35952
better traces and msgs (#17517)
memsharded 61bbb81
Feature/workspace api (#17501)
memsharded cd2ac2d
update webtest testing version (#17537)
memsharded d470bac
proposing new --format=<format> --out-file=<file.ext> feature (#17507)
memsharded 630ff54
Test/remote login (#17552)
memsharded e9518da
Keep sessions around between each ConanRequester (#17455)
AbrilRBS dcfa303
Add rest of posible `ConanBasicApp` usages (#17555)
AbrilRBS df0525c
Improve typing information in remove sub API (#17564)
marlamb 2c09f1f
small refactor to PkgConfigDeps (#17568)
memsharded 099481c
Updated to use maxsplit=1 (#17571)
maitrey 76a30fe
refactor moving model conans->conan (#17572)
memsharded d4328b5
allow non trim_conandata
memsharded e13458b
removed print
memsharded e32c930
Merge branch 'develop2' into feature/extra_patche_path
memsharded File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is important @AbrilRBS @jcar87
This was not done before, but it seems it make sense, otherwise
self.conan_data
in recipes can have outdated/trimmed information. Please check if this could be an issue in any ConanCenter flow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not an issue in the current CCI CI, as the current flow is to first export each version separatedly, and upload it to a staging repo from which workers can then download it to build them, so the create/install is done on an already trimmed recipe conandata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The possible issue would be if some custom command or something was reading
conanfile.conandata
after theexport
that trimmed it and somehow reading other versions information too. I doubt this happens ,but just in caseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm, we don't use
trim_conandata()
(yet) in any recipe in Conan Center, so I'm unsure as to how this change can be currently relevant?This makes sense regardless, but seems possibly unrelated to the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result for the shake of validation should be the same, the important thing is to have the final exported
conandata.yml
trimmed or not. It doesn't matter if it is trimmed by the ConanCenter hook or by the recipe, what is important is that theexport_conandata_patches
is resilient to either case, having it trimmed or not, and that is what the new checks validate.