moving code from cli to conan_api #17575
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Jan 15, 2025
AbrilRBS
reviewed
Jan 16, 2025
| ******************************************************************* | ||
| private '{}' | ||
| detected in user code (custom commands, extensions, recipes, etc). | ||
| Stop using it, use only public documented APIs. |
There was a problem hiding this comment.
Do we want to warn/scare users saying that we will break this usage in the future?
There was a problem hiding this comment.
Do you mean it is not scary enough? 😅
I can explicit that it will break, sure.
czoido
reviewed
Jan 16, 2025
Comment on lines
+4
to
+10
| _msg = """ | ||
| ******************************************************************* | ||
| private '{}' | ||
| detected in user code (custom commands, extensions, recipes, etc). | ||
| Stop using it, use only public documented APIs. | ||
| ******************************************************************* | ||
| """ |
There was a problem hiding this comment.
Minor thing but I think we may add a please there (and for all the others)
Suggested change
| _msg = """ | |
| ******************************************************************* | |
| private '{}' | |
| detected in user code (custom commands, extensions, recipes, etc). | |
| Stop using it, use only public documented APIs. | |
| ******************************************************************* | |
| """ | |
| _msg = """ | |
| ******************************************************************* | |
| Private '{}' detected in user code (custom commands, extensions, recipes, etc). | |
| Please stop using it and use only public, documented APIs. | |
| ******************************************************************* | |
| """ |
czoido
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
Refactor, moving code from
clithat were accessingfrom conansorfrom conan.internalto using public API.