Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unzip pattern and strip_root should be used together #17591

Open
wants to merge 1 commit into
base: develop2
Choose a base branch
from

Conversation

jusito
Copy link

@jusito jusito commented Jan 17, 2025

Changelog: Bugfix for unzip because it should be possible to use pattern and strip_root at the same time.
fixes #14455

Found today that during archive extraction pattern and strip_root can't be used together. Same as in the related issue I would expect that pattern is applied before strip_root but actually they currently can't be used together at all.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
    • no info required because expected behaviour restored
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.
    • I guess this doesn't apply here?

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded added this to the 2.12.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strip_root behaviour with pattern differs between tools.unzip and tools.untargz
3 participants