Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build number for rerendering #56

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 11, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Hey folks, just a bogstandard rebuild trigger with bumped build number =1 so you can accommodate the new Python=3.12, so iris and iris-esmf-regrid can then be happy with cf-units. Please disregard if Python=3.12 is creating issues upstream (have not seen any signs of them though).

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@valeriupredoi
Copy link
Contributor Author

@conda-forge-admin, please rerender

@trexfeathers
Copy link
Contributor

@valeriupredoi looking at the CI suggests this still isn't supporting Python 3.12. Is that your understanding too? Any ideas why?

@ocefpaf
Copy link
Member

ocefpaf commented Oct 12, 2023

Any ideas why?

The bot will issue the migration PR soon, if not we can check it's logs to see if there's anything wrong. However, during the migration period, rerendering won't add py312.

@trexfeathers
Copy link
Contributor

Thanks @ocefpaf!

@valeriupredoi are you happy to wait?

@trexfeathers trexfeathers changed the title Rebuild for Python=3.12 (bump build number) Bump build number for rerendering Oct 12, 2023
@trexfeathers
Copy link
Contributor

We're gonna merge it anyway for latest NumPy support then we'll return to this for 3.12 later.

@trexfeathers trexfeathers merged commit f92420e into conda-forge:main Oct 12, 2023
@valeriupredoi
Copy link
Contributor Author

Hey folks, my apologies, I should have checked but @zklaus did that - it appears cf-units is not solving yet for 3.12 at http://conda-forge.org/status - could be that I jumped the gun and we should let the bot do its job? 🍺

@valeriupredoi valeriupredoi deleted the rebuild_python312 branch October 12, 2023 11:23
@valeriupredoi
Copy link
Contributor Author

just saw the merge - cheers both @trexfeathers and @ocefpaf - and my apologies if I was a bit too cavalier and didn't wait for the 🤖

@ocefpaf
Copy link
Member

ocefpaf commented Oct 12, 2023

BTW, the main blocker in the migration is antlr-python-runtime. See SciTools/cf-units#313 for more context.

@trexfeathers
Copy link
Contributor

BTW, the main blocker in the migration is antlr-python-runtime. See SciTools/cf-units#313 for more context.

Cool, that will be sorted at the next release (hopefully soon), then we can deal with 3.12 after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants