Add process for SIG-Node collaboration #234
Conversation
samuelkarp
force-pushed
the
sig-node-collaboration-process
branch
from
c01c2b2 to
f5a26ab
Compare
|
@containerd/committers |
samuelkarp
force-pushed
the
sig-node-collaboration-process
branch
from
f5a26ab to
f955528
Compare
content/keps.md
Outdated
| development and implementation of CRI. | ||
|
|
||
| Changes to Kubernetes (including CRI) are primarily driven through the | ||
| Kubernetes Enhancement Proposal (KEP) process. KEPs are proposed to individual |
content/keps.md
Outdated
| [containerd/containerd](https://github.com/containerd/containerd) repository | ||
| for tracking KEPs that require CRI changes in the container | ||
| runtime or one of our other containerd subprojects. (This includes | ||
| relatively minor changes, such as a runc update or checking containerd config |
There was a problem hiding this comment.
"runc update" means updating the /usr/local/sbin/runc binary (for the CI) or the runc update command?
At least the former one rarely relates to a KEP especially for patch releases, and does not seem to need an issue ticket.
There was a problem hiding this comment.
@mikebrow suggested this set of examples; I think it means updating the runc binary.
There was a problem hiding this comment.
yes I meant even the minor issue of updating the runc-version file over in script/ in this case...
I have agreed with the point that it does not seem we need an issue ticket in every case.. Believe we had a thread where you and I agreed some changes are so easy and obvious that we just get it done in a quick PR and you can mark that as done over in the actual KEP issue in k/enhancements where it's being discussed.
After a long discussion with Sam I was swayed to agreement for the process where even for the easy stuff, if there is something to track in the KEP description/PR then we should open an issue in c/c. "just in case" For example someone may know of an issue with moving up to that version of runc that would delay merge.
This adds public documentation of the process for containerd project collaboration with Kubernetes SIG-Node. It is mostly a formalization of what we have already been doing informally, but the formalization should help with visibility and work distribution. Relates to containerd/project#141 Signed-off-by: Samuel Karp <samuelkarp@google.com>
samuelkarp
force-pushed
the
sig-node-collaboration-process
branch
from
f955528 to
f0f25b6
Compare
This adds public documentation of the process for containerd project collaboration with Kubernetes SIG-Node. It is mostly a formalization of what we have already been doing informally, but the formalization should help with visibility and work distribution.