[REFACTOR]: consolidate filesystem ops into internal pkg #4245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suggests that we consolidate low-level filesystem related operations into one package (currently pepperred over under
lockutil
andstore
).This includes path validation, atomic writes, locks.
Also suggesting that said package should be made internal. This is not nerdctl API, but merely low-level primitives, and generally speaking the nerdctl API is just too big, exposing too much irrelevant stuff.
This refactor is in preparation for future PRs that will focus on:
(they will be broken out of [FUTURE] [EXP] filesystem package #4240 as well in small chuncks)
This PR here sticks with purely refactoring.