Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Justin Terry as a Reviewer #11

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Add Justin Terry as a Reviewer #11

merged 1 commit into from
Oct 26, 2018

Conversation

crosbymichael
Copy link
Member

Justin has been contributing to both the core containerd daemon and CRI
code getting Windows working.

The code has been inline with the project's goals and design to make a
very simple and robust implementation.

His reviews on other runtime and storage related code has been valuable
and has been working consistently on the project for the past few
months.

cc @jterry75

Signed-off-by: Michael Crosby crosbymichael@gmail.com

Justin has been contributing to both the core containerd daemon and CRI
code getting Windows working.

The code has been inline with the project's goals and design to make a
very simple and robust implementation.

His reviews on other runtime and storage related code has been valuable
and has been working consistently on the project for the past few
months.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@dmcgowan
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member Author

LGTM

@lowenna
Copy link

lowenna commented Oct 26, 2018

LGTM 🎈

@dmcgowan
Copy link
Member

The reviewer role has the same process but only requires 33% of current maintainers.

5/14, merging

@dmcgowan dmcgowan merged commit c68f9a2 into master Oct 26, 2018
@crosbymichael crosbymichael deleted the terry branch October 26, 2018 18:24
@jterry75
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants