Promote Justin Terry (@jterry75) from reviewer to maintainer #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <jhoward@microsoft.com>
|
LGTM |
|
LGTM |
mlaventure
approved these changes
Feb 28, 2019
|
LGTM |
abhi
approved these changes
Feb 28, 2019
|
Wahoo!! Thanks everyone! |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
Justin has been doing some extremely valuable work in the containerd repos for many months now to get both runtime and snapshotters for containerd ported to Windows. I think it's time we recognize that work, his ongoing contributions, and engineering excellence by promoting him from a project reviewer to maintainer.
Governance requires a LGTM from at least 66% (or 8) of the current 12 maintainers (https://github.com/containerd/project/blob/master/GOVERNANCE.md#adding-maintainers)
cc Existing reviewers FYI: @dqminh @hqhq @yanxuean @miaoyq @ehazlett @fuweid @Ace-Tang. And, of course, @jterry75