Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Maksym to maintainer #31

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Sep 30, 2019

Maksym has been shown commitment to maintaining containerd by consistently reviewing changes, implementing needed features, and fixing bugs. He has demonstrated an understanding of the mission and scope of containerd. He will make an excellent maintainer to help uphold the mission and quality of containerd.

8 maintainer LGTM required (2/3) + new maintainer

Maksym has been shown commitment to maintaining containerd
by consistently reviewing changes, implementing needed
features, and fixing bugs. He has demonstrated an understanding
of the mission and scope of containerd. He will make an
excellent maintainer to help uphold the mission and quality
of containerd.

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Copy link
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Random-Liu
Copy link
Member

LGTM

@crosbymichael
Copy link
Member

We have 10 out of the 8 required. Lets merge this.

Welcome

@crosbymichael crosbymichael merged commit 6f85288 into containerd:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants