Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Samuel Karp as committer #90

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Jun 1, 2022

Sam is a long time contributor and user of containerd. He has helped out in many roles including reviewer, security advisor, as well as helping out with design feedback and getting directly involved in the security release process. He has shown a strong commitment to maintaining the overall project quality and understanding of the project scope.

10 committer LGTM required (2/3 of 14 committers) + new committer

Sam is a long time contributor and user of containerd. He has helped out
in many roles including reviewer, security advisor, as well as helping
out with design feedback and getting directly involved in the security
release process. He has shown a strong commitment to maintaining the
overall project quality and understanding of the project scope.

Signed-off-by: Derek McGowan <derek@mcg.dev>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
Copy link
Member

dims commented Jun 1, 2022

BIG +1000

@kzys
Copy link
Member

kzys commented Jun 1, 2022

For sure!

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevpar
Copy link
Member

kevpar commented Jun 1, 2022

LGTM!

Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome

Copy link
Member

@crosbymichael crosbymichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan
Copy link
Member Author

dmcgowan commented Jun 9, 2022

The 7 days has passed and we have reached 2/3 quorum. Welcome Sam as committer!

@dmcgowan dmcgowan merged commit 0934c00 into containerd:main Jun 9, 2022
@samuelkarp
Copy link
Member

Thank you! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.