Compiler: Bump protobuf #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tim-Zhang PTAL |
jsturtevant
reviewed
Mar 20, 2025
|
I think we can bump the ttrpc-compiler's version to 0.8.0, because the parameters's type of gen_and_write was changed, we need a major version bump. |
|
The commit messages can be more specific such as |
Bump usage of the protobuf and protobuf-codegen crates to 3.7.2. These versions include a fix to the advisory RUSTSEC-2024-0437 Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
added a commit
to jprendes/ttrpc-rust
that referenced
this pull request
Apr 3, 2025
Bump crate versions for publishing. The compiler crate needs a major version bump after breaking changes introduced by PR containerd#291 The main crate needs a major version bump after the braking changes introduced by PR containerd#290 Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
bump-protobuf
branch
2 times, most recently
from
59539ad to
8835cfd
Compare
jprendes
added a commit
to jprendes/ttrpc-rust
that referenced
this pull request
Apr 3, 2025
Bump crate versions for publishing. The compiler crate needs a major version bump after breaking changes introduced by PR containerd#291 The main crate needs a major version bump after the braking changes introduced by PR containerd#290 Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
bump-protobuf
branch
2 times, most recently
from
76a6365 to
2d04934
Compare
jprendes
added a commit
to jprendes/ttrpc-rust
that referenced
this pull request
Apr 3, 2025
Bump crate versions for publishing. The compiler crate needs a major version bump after breaking changes introduced by PR containerd#291 The main crate needs a major version bump after the braking changes introduced by PR containerd#290 Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Bumping protobuf and protobuf-codegen to 3.7.2 breaks the ttrpc-codegen and ttrpc-compiler crates. Both of these crates were using the 2.27.1 version of the protobuf crates. This commit fixes the breaking changes introduced by the bump in major version. Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
added a commit
to jprendes/ttrpc-rust
that referenced
this pull request
Apr 3, 2025
Bump crate versions for publishing. The compiler crate needs a major version bump after breaking changes introduced by PR containerd#291 The main crate needs a major version bump after the braking changes introduced by PR containerd#290 Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Tim-Zhang
reviewed
Apr 9, 2025
Add net feature to tokio to support UDS Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
move the different functionalities vendored from older protobuf versions into more descriptive modules within the util module. Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
|
Moving the workspace changes to a new PR. |
Open
|
I opened #294 for the workspace changes |
jprendes
added a commit
to jprendes/ttrpc-rust
that referenced
this pull request
Apr 9, 2025
Bump crate versions for publishing. The compiler crate needs a major version bump after breaking changes introduced by PR containerd#291 The main crate needs a major version bump after the braking changes introduced by PR containerd#290 Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
added a commit
to jprendes/ttrpc-rust
that referenced
this pull request
Apr 9, 2025
Bump crate versions for publishing. The compiler crate needs a major version bump after breaking changes introduced by PR containerd#291 The codegen crate needs a major version bump because it exports an item from the compiler crate. The main crate needs a major version bump after the braking changes introduced by PR containerd#290 Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an advisory on the
protobufcrate: https://rustsec.org/advisories/RUSTSEC-2024-0437This advisory requires bumping
protobufto3.7.2.ttrpc-rustis using a2.27.1version ofprotobufinttrpc-codegenandttrpc-compiler.It looks like there is no intention to fix the advisory in the
2.xversion ofprotobuf: stepancheg/rust-protobuf#756 (comment)This PR bumps all uses of
protobufin the repo to3.7.2, and fixes the breaking changes introduced by the update from2.27.1 -> 3.7.2.