Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow version 5.1.3 of web-auth/webauthn-symfony-bundle #75

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

leofeyer
Copy link
Member

Both our issues are fixed in version 5.1.3

@fritzmg
Copy link
Contributor

fritzmg commented Mar 10, 2025

Shouldn't it be also fixed in 5.1.2, according to web-auth/webauthn-framework#680 (comment) ?

@leofeyer
Copy link
Member Author

leofeyer commented Mar 10, 2025

web-auth/webauthn-framework#680 has been fixed in version 5.1.2, but web-auth/webauthn-framework#698 only in version 5.1.3. We need both fixes.

@leofeyer leofeyer merged commit 7b02132 into main Mar 10, 2025
@leofeyer leofeyer deleted the leofeyer-patch-1 branch March 10, 2025 11:28
@fritzmg
Copy link
Contributor

fritzmg commented Mar 10, 2025

but web-auth/webauthn-framework#698 only in version 5.1.3. We need both fixes.

The conflict was only intended for web-auth/webauthn-framework#680

#7890 does not break the application. If we want a conflict for that, we would need to add even more versions, as the json data type is used in all previous versions. But that would make no sense - as this issue is just cosmetic.

But in the end it does not really matter 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants