Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Loading and Org/Profile Selection Fixes #5013

Merged
merged 16 commits into from
Apr 7, 2025

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Apr 6, 2025

Description

  • Changes org/profile loading to a safer single-vertical cascading pattern
  • Fixes various bugs with assistant and org selection race conditions etc.
  • all orgs/profiles loaded on startup unless manually refreshed
  • With new data structure, unifies org/profile redux slices
  • Adds refresh all button to assistant select list
  • Clicking the org in the assistant listbox cycles orgs rather than navigating away

@RomneyDa RomneyDa requested a review from a team as a code owner April 6, 2025 22:07
@RomneyDa RomneyDa requested review from sestinj and removed request for a team April 6, 2025 22:07
Copy link

netlify bot commented Apr 6, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 8eb97b1
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67f314092895d90008f74d7c

Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. I looked closely mostly at ConfigHandler, and spent the rest of my time testing. Only odd case I found is when you click the org name in the assistant switcher popover and it cycles to an org without profiles, then the popover disappears. Obviously doesn't need to be fixed for this PR

@RomneyDa RomneyDa merged commit 8acc20a into main Apr 7, 2025
31 checks passed
@RomneyDa RomneyDa deleted the dallin/assistant-switch-fixes branch April 7, 2025 06:01
@RomneyDa RomneyDa mentioned this pull request Apr 7, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants