Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shortcuts component to render keyboard shortcuts on KeyboardShortcuts.tsx #5016

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

shermanhuman
Copy link
Contributor

Description

Using fancy shortcuts for keyboard shortcuts. Added some alternating rows and better handling when sidebar is small:

Original:
image

Original cramped layout:
image

Improved version:
image

Improved cramping:
image

Testing instructions

  • Tested on Windows / VS Code
  • [] Tested on Windows / Jetbrains
  • Test on Mac / VS Code
  • [] Test on Mac / Jetbrains

VS Code: Open settings>Shortcuts. Try setting sidebar to different widths.
Jetbrains: not sure

Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 7f36a8b
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67f3277a7ae55700080c7b63

@shermanhuman shermanhuman marked this pull request as ready for review April 7, 2025 18:15
@shermanhuman shermanhuman requested a review from a team as a code owner April 7, 2025 18:15
@shermanhuman shermanhuman requested review from sestinj and removed request for a team April 7, 2025 18:15
@Patrick-Erichsen
Copy link
Collaborator

Patrick-Erichsen commented Apr 8, 2025

Here is IntelliJ - it seems as if the key cap styling isn't being applied. Also minor nitpick but I feel that the individual rows could use a bit of horizontal padding so the text isn't flush with the border.
image

@shermanhuman
Copy link
Contributor Author

Thanks. Yeah I think the shortcuts glyph component probably needs a conditional for Jetbrains and some specific styling.

The table colors should probably tie into the VS Code and Jetbrains themes. I chose a barely lighter than the background color, as I like a subtle look. But it might be better to just go with the something from the themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants