Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Aug 21, 2025

Description

Scroll to the first diff after apply completes irrespective of where the cursor is.

resolves CON-2190

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

feat.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Scroll to the first diff after applying changes, centering the editor on that line regardless of the current cursor. Addresses Linear CON-2190.

  • New Features
    • Capture the first changed line before clearing decorations and reveal it InCenter after apply.
    • Works even if the cursor was moved elsewhere during the apply.

@uinstinct uinstinct marked this pull request as ready for review August 22, 2025 06:08
@uinstinct uinstinct requested a review from a team as a code owner August 22, 2025 06:08
@uinstinct uinstinct requested review from tingwai and removed request for a team August 22, 2025 06:08
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 22, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct the goal is to stream to the first diff after apply finishes streaming, not after it is closed. The view should not move when diffs are accepted/rejected

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 22, 2025
@uinstinct uinstinct closed this Aug 27, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 27, 2025
@uinstinct uinstinct deleted the scroll-to-diff branch August 27, 2025 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants