Skip to content

fix: grep escaped chars and empty results #7323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Aug 22, 2025

Description

  • Adds handling for improperly escaped chars in grep patterns post JSON-parsing, along with explanations for the model in case this fails
  • Makes truncation warning context items for various tools less ugly by removing unnecessary description and shortening name
  • Bumps grep token limit from ~1000 to ~1500
  • Adds meaningful no-result context items for glob and grep queries that return zero results

CON-3953
CON-3497

@RomneyDa RomneyDa requested a review from a team as a code owner August 22, 2025 06:58
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team August 22, 2025 06:58
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 22, 2025
Copy link

AI Code Review

AI review completed but failed to parse output

No specific line comments generated.


💡 To request a new detailed review, comment @continue-detailed-review

Copy link

⚠️ AI review completed but no review output was generated. Check the action logs for details.


💡 To request a new review, comment @continue-general-review

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 13 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant