Handle dual access grids (full implementation) #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorgerhardt
force-pushed
the
full-grid-dual-access
branch
2 times, most recently
from
8f5ab96 to
ad4e9fa
Compare
- Switch to use a thresholds array instead of a single threshold in `AnalysisWorkerTask`s. - Check that only a single grid is being created (they currently would have the same filename) - Create a `MultiGridResultWriter` for dual access grids. Store dual access results in `accessibilityValues` in `RegionalWorkResult`.
As requested in #935 (comment)
Handle `threshold` taken as the query parameter and when to check for `cutoffsMinutes` vs `dualAccessibilityThresholds`.
trevorgerhardt
force-pushed
the
full-grid-dual-access
branch
from
c7a9ef7 to
8e5586d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and write dual accessibility grids utilizing the same grid format as regular accessibility grids. A new
dualAccessibilityThresholdsparameter is required along withincludeTemporalDensityset to true.Changes:
AnalysisWorkerTasks.MultiGridResultWriterfor dual access grids. Store dual access results inaccessibilityValuesinRegionalWorkResult.getRegionalResultsto takethresholdas a parameter instead ofcutoff.