Fix New User Google Login/Register Issue #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 124. |
BrianLa0616
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Your changes allow for relogin. However, there's now an issue where an existing user is redirected to the registration change every time.
Specifically, this is because of the error that is thrown "flutter: Error occurred while checking user: FormatException: Unexpected character (at character 1)"
Merging from master branch to resolve potential conflicts
BrianLa0616
approved these changes
Nov 19, 2024
shah-esha
pushed a commit
that referenced
this pull request
Dec 4, 2024
* Fixed local machine dependency issues * Fixed the issue of registering new users on simulator * Added documentation for login related pages * Fixed the wrong uri call for checking user existence * Removeed loggings that are used for debugging * Made check user existence logic concise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the problem when users cannot log in/register on the simulator if their information is not in the database.
Dependency fixes are the same as #229
Test Plan
Notes
If we call Geolocator.getCurrentPosition() twice on the simulator, it will stuck forever. (in geopoint.dart)