Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course color and credits dropdown #808

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Course color and credits dropdown #808

merged 3 commits into from
Apr 11, 2023

Conversation

KaylinChan
Copy link
Contributor

@KaylinChan KaylinChan commented Mar 30, 2023

Summary

This PR changes the Course Menu Edit Color and Edit Credits sections to drop downwards. It addresses this issue: #704

Before:
When you hover over the edit color button, the color modal will sometimes go to the right, sometimes to the left, and sometimes off screen. The same occurs with the credits modal on courses like CS 4999 where you can edit the number of credits.

After:
Now, both the color and credits modals drop downwards so that they will never go offscreen and there is more consistency in the user experience.

Test Plan

  • On any course, hover over Edit Color and see if the color modal opens downwards, directly under. Click on various colors to test if the functionality remains.

image

  • On a course like ORIE 4999 or CS 4999, hover over Edit Course and see if the credits modal opens downwards. Click on various credits to test if the functionality remains.

image

  • Experiment with different screen sizes, default vs. compact view, zooming in and out to see if the dropdown is still downward aligned.

@KaylinChan KaylinChan requested a review from a team as a code owner March 30, 2023 18:57
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 48.

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit a6d616f):

https://cornelldti-courseplan-dev--pr808-course-color-dropdow-ty7u1y4y.web.app

(expires Sat, 29 Apr 2023 18:59:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

@KaylinChan KaylinChan added the front-end Front-end improvement or feature label Mar 30, 2023
Copy link
Collaborator

@zachary-kent zachary-kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks for the CSS wizardry!

@KaylinChan KaylinChan merged commit 9627394 into master Apr 11, 2023
@KaylinChan KaylinChan deleted the course-color-dropdown branch April 11, 2023 21:35
@noschiff noschiff mentioned this pull request Apr 26, 2023
22 tasks
This was referenced May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Front-end improvement or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants