WIP: Implement frontend for all modals to add, delete and edit plans. #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Script Design * implemented courses fetching * Implemented Script * Add appropriate documentation to script * Update package-lock.json * Fixed type annotation for retrieveAvailableCourses Co-authored-by: zachary0kent <73757337+zachary0kent@users.noreply.github.com> * Fixed type annotation for retrieveAvailableSubjects Co-authored-by: zachary0kent <73757337+zachary0kent@users.noreply.github.com> * Update courses-populate.ts * Update courses-populate.ts * Fix populateCourses async issue Ensure that a course's async operations finish before iterating to the next one. * Quality of Life Fixes Removed chained thens, made new populations directory, and moved clean filters to utilities. * Saving courseFieldFilter --------- Co-authored-by: zachary0kent <73757337+zachary0kent@users.noreply.github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.74.0 to 5.76.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.74.0...v5.76.1) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* created course retrieval function and defined new course interface * lint * type annotations, docs, and variable retrieval mode * lint * Update src/global-firestore-data/courses.ts Co-authored-by: zachary0kent <73757337+zachary0kent@users.noreply.github.com> * implement other retrieval methods later * prettier * abstracted last offer course to another function * retrieve course data via crseId * stylistic change * remove type assertion * Update courses.ts --------- Co-authored-by: zachary0kent <73757337+zachary0kent@users.noreply.github.com>
* Implemented new data science minor * implemented new animal science minor * implemented new animal science minor * implemented new animal science minor * implemented animal science major * updated animal science checker * forgot to add some files * refactored code for checker (including special studies) * ran format checker to pass tests * fixed linter errors in animal-sci.ts * reverted back pack-lock.json * Reverted package.json changes from master * fixed special courses to only include 49** courses
* Make color and credits drop downwards instead of to the side * Create z-indexes for the modals to put the correct one on top * Fixed aesthetics and alignment of dropdowns
* replace class roster API call with firebase call * restore bug for separate PR fix * Update user-data.d.ts * fetching courses from firestore * debug * Retrieve courses from Firestore for BottomBar component * Handle course retrieval when roster not available * remove unused code * removed redundant semester/year format converter * refactor using common functions in courses.ts * Update BottomBarState.ts * added season and year to incomplete sub req * Update IncompleteSubReqCourse.vue * optional prop params * updated accessibility test * test stuff * fix accessibility test * updated implementation of helper function * type assertion on function argument * nits n stuff * object.assign()
* Parsed Other Yes List * Run npm format * Run npm lint * Changed typscript version * Reinstalled packages as dev dependencies and cleaned up extra code * Added upper bound to typescript version * Fixed jest tests * Installed as dev dependencies * Changed cols to enum type * run npm format * run npm format again * Deleted commented code * npm run format * removed try catch * added break * removed pdf to excel dependency * remove pdfjs dist
* replace class roster API call with firebase call * restore bug for separate PR fix * Update user-data.d.ts * fetching courses from firestore * debug * Retrieve courses from Firestore for BottomBar component * Handle course retrieval when roster not available * remove unused code * removed redundant semester/year format converter * refactor using common functions in courses.ts * Update BottomBarState.ts * added season and year to incomplete sub req * Update IncompleteSubReqCourse.vue * optional prop params * updated accessibility test * test stuff * fix accessibility test * updated implementation of helper function * type assertion on function argument * nits n stuff * object.assign() * populate specific roster script * refactor functions * pass roster through command line * Update populate-specific-roster.ts
* Parsed Other Yes List * Run npm format * Run npm lint * Changed typscript version * Reinstalled packages as dev dependencies and cleaned up extra code * Added upper bound to typescript version * Fixed jest tests * Installed as dev dependencies * Changed cols to enum type * run npm format * run npm format again * validate parsed courses * changed name to fullCoursesArray * create script for fetching other yes list * run npm tests * remove pdfjs-dist and save json to src/assets/courses * move json file
* Parsed Other Yes List * Run npm format * Run npm lint * Changed typscript version * Reinstalled packages as dev dependencies and cleaned up extra code * Added upper bound to typescript version * Fixed jest tests * Installed as dev dependencies * Changed cols to enum type * run npm format * run npm format again * validate parsed courses * changed name to fullCoursesArray * create script for fetching other yes list * run npm tests * modified liberal studies checker * run mpm prettier * disable lint for any
* implemented cleansing function * Explains what NBS is * Format
|
[diff-counting] Significant lines: 2533. This diff might be too big! Developer leads are invited to review the code. |
|
Visit the preview URL for this PR (updated for commit e266607): https://cornelldti-courseplan-dev--pr830-plans-add-modal-659dqitg.web.app (expires Tue, 21 Nov 2023 10:31:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
zachary-kent
reviewed
May 6, 2023
* Bypass CI Check for Release Branch * remove logging
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 2.9.13 to 2.9.16. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v2.9.16/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v2.9.16/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Implements a 'serve:prod' script, allowing devs to build and test CoursePlan locally for production.
mirandayu131
requested changes
Sep 17, 2023
* Run courses script for FA23 * Fix CS 1110 Frontend Test Corrects the CS 1110 frontend test with the new course title
* add pipfile and prereq_parse * fix * fixes * add documentation * add parsing * working * black and ci * ci * black * fix tests * add gpt utils * fix ci * download langchain * api key * ci * remove pip * update pip * fix * fixes * tests * black hook * pipfile * out of sync * pipenv * pipenv * pipfile * update pipfile * cat * cat * cat * cat * cat * cat * check * check pipfile broken * fix pipfile * change wd * nits * fix
Co-authored-by: Nidhi Mylavarapu <nm549@cornell.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work in progress!!
Finish implementing frontend for all modals for add, delete and edit plans.
10/22/23 Updates
11/12/23 Updates
Remaining TODOs:
10/22/23 Updates
Test Plan
Documentation will be here: https://www.notion.so/courseplan/Multiple-Plans-c01b61f8a7a9473781539dc4ec24a5d9