[Schedule Generator] Add Schedule Modal #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 147. |
|
Visit the preview URL for this PR (updated for commit 3d343fe): https://cornelldti-courseplan-dev--pr892-andrew-generate-sch-22iqnoio.web.app (expires Sat, 06 Apr 2024 01:56:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
andxu282
force-pushed
the
schedule_builder_icon
branch
from
c1099a1 to
db8b57f
Compare
andxu282
force-pushed
the
andrew--generate-schedule-modal
branch
2 times, most recently
from
e408457 to
036172f
Compare
andxu282
changed the base branch from
schedule_builder_icon
to
simon/scheduler-sidebar-panel-header
andxu282
force-pushed
the
andrew--generate-schedule-modal
branch
from
0ba6e67 to
4fc4768
Compare
andxu282
force-pushed
the
simon/scheduler-sidebar-panel-header
branch
from
06e2514 to
bc4cc53
Compare
Base automatically changed from
simon/scheduler-sidebar-panel-header
to
schedule-generator
March 5, 2024 20:37
* Run courses script for FA23 * Fix CS 1110 Frontend Test Corrects the CS 1110 frontend test with the new course title
andxu282
force-pushed
the
andrew--generate-schedule-modal
branch
from
b1ec63e to
3d343fe
Compare
Destaq
reviewed
Mar 11, 2024
| @@ -282,6 +291,15 @@ export default defineComponent({ | |||
| } | |||
| }, | |||
|
|
|||
| openScheduleGenerateModal() { | |||
| // TODO: do feature flag check | |||
There was a problem hiding this comment.
Though... do you still need to do this before merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Schedule Modal to pop up when the "Generate" button is clicked.
Depends on #880
Test Plan
Screen.Recording.2024-03-02.at.4.33.04.PM.mov