Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schedule Generator] Schedules Component #897

Closed

Conversation

andxu282
Copy link
Collaborator

@andxu282 andxu282 commented Mar 6, 2024

Summary

Implements the frontend for the Schedules component of the Schedules modal.

Remaining TODOs:

  • Add gray lines
  • Make sure that the days don't move if they don't have classes
  • Compute the total number of pixels
  • Compute the end time as well to make the length of the class be reflected

Will address the following in a future PR

  • Compute min and max hours
  • Compute total number of minutes

Depends on #893

Test Plan

Screenshot 2024-03-06 at 6 01 31 PM

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ andxu282
✅ Destaq
✅ zachary-kent
❌ Andrew Xu


Andrew Xu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Andrew Xu and others added 2 commits March 13, 2024 17:49
@andxu282 andxu282 force-pushed the andrew--schedules-component branch from 5af0ffa to 3fcb5ff Compare March 13, 2024 22:57
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 743.

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 3fcb5ff):

https://cornelldti-courseplan-dev--pr897-andrew-schedules-co-6nzkmk0n.web.app

(expires Fri, 12 Apr 2024 23:02:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

@andxu282 andxu282 changed the base branch from schedule-generator to simon--courses-component March 18, 2024 22:19
@andxu282 andxu282 closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants