-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove baseapp from x/accounts
#23355
Open
aljo242
wants to merge
55
commits into
main
Choose a base branch
from
chore/remove-baseapp-accounts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+274
−221
Open
Changes from 54 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
dab4f61
header service
aljo242 ccdbad4
update
aljo242 ef438eb
basic env
aljo242 9dfae05
transaction service
aljo242 779bd84
refit
aljo242 2e7ca6d
register
aljo242 6161b6a
utd
aljo242 7355259
Merge branch 'main' into feat/services-helpers
aljo242 46a30d3
bank
aljo242 89e5b26
no more sdk.context
aljo242 05a8577
working
aljo242 f827e73
lint fixes
aljo242 6c7dc2a
format
aljo242 ed63aca
Merge branch 'main' into feat/services-helpers
aljo242 c8b7460
Merge branch 'main' into feat/services-helpers
aljo242 4956083
lint
aljo242 b5703d4
Merge branch 'main' into feat/services-helpers
aljo242 c7bc69d
tidy all
aljo242 1442dc2
Merge branch 'main' into feat/services-helpers
aljo242 9d98953
Merge branch 'main' into feat/services-helpers
aljo242 d29ed65
Merge branch 'main' into feat/services-helpers
aljo242 d42ac1f
clean
aljo242 a6ffa04
use mocked query client
aljo242 fb55664
clean up
aljo242 87fb4f9
lint
aljo242 e18d809
server check
aljo242 4f56126
Merge branch 'main' into feat/services-helpers
aljo242 f67b33f
lint-fix
aljo242 997bf85
Merge branch 'main' into feat/services-helpers
aljo242 ed61ace
Merge branch 'main' into feat/services-helpers
aljo242 47a681e
init test
aljo242 9f54324
rm
aljo242 0cea6dd
Merge branch 'main' into feat/services-helpers
aljo242 1838bbf
Update testutil/queryclient/queryclient.go
aljo242 31198b6
Merge branch 'main' into feat/services-helpers
aljo242 e932ea5
q
aljo242 d17569e
Merge branch 'main' into feat/services-helpers
aljo242 71ad965
Merge branch 'main' into feat/services-helpers
aljo242 4069c71
Merge branch 'main' into feat/services-helpers
aljo242 d759e14
move out of intrgration
aljo242 d8b3ac6
rearrange
aljo242 150df47
lint fix
aljo242 86269ec
clean
aljo242 ffde8e3
clean
aljo242 6574b36
Merge branch 'main' into chore/remove-baseapp-accounts
aljo242 b5cf3af
Merge branch 'main' into chore/remove-baseapp-accounts
aljo242 1138fc9
Merge branch 'main' into chore/remove-baseapp-accounts
aljo242 6caaa63
refactgor into coretesting
aljo242 d444dd7
Merge branch 'main' into chore/remove-baseapp-accounts
aljo242 1b9b8f7
refactor
aljo242 eda6e7f
Merge branch 'main' into chore/remove-baseapp-accounts
aljo242 47bdcde
clean
aljo242 5d14883
fix
aljo242 615d930
Merge branch 'main' into chore/remove-baseapp-accounts
aljo242 f88a742
Merge branch 'main' into chore/remove-baseapp-accounts
aljo242 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,23 @@ | ||
| module cosmossdk.io/core/testing | ||
|
|
||
| go 1.23 | ||
| go 1.23.1 | ||
|
|
||
| toolchain go1.23.4 | ||
|
|
||
| require ( | ||
| cosmossdk.io/core v1.0.0 | ||
| github.com/cosmos/gogoproto v1.7.0 | ||
| github.com/tidwall/btree v1.7.0 | ||
| go.uber.org/mock v0.5.0 | ||
| google.golang.org/grpc v1.69.4 | ||
| ) | ||
|
|
||
| require cosmossdk.io/schema v1.0.0 // indirect | ||
| require ( | ||
| cosmossdk.io/schema v1.0.0 // indirect | ||
| github.com/google/go-cmp v0.6.0 // indirect | ||
| golang.org/x/net v0.33.0 // indirect | ||
| golang.org/x/sys v0.28.0 // indirect | ||
| golang.org/x/text v0.21.0 // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20241015192408-796eee8c2d53 // indirect | ||
| google.golang.org/protobuf v1.35.1 // indirect | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| package msgrouter | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| gogoproto "github.com/cosmos/gogoproto/proto" | ||
|
|
||
| "cosmossdk.io/core/router" | ||
| "cosmossdk.io/core/transaction" | ||
| ) | ||
|
|
||
| // msgTypeURL returns the TypeURL of a proto message. | ||
| func msgTypeURL(msg gogoproto.Message) string { | ||
| return gogoproto.MessageName(msg) | ||
| } | ||
|
|
||
| type routerHandler func(context.Context, transaction.Msg) (transaction.Msg, error) | ||
|
|
||
| var _ router.Service = &RouterService{} | ||
|
|
||
| // custom router service for integration tests | ||
| type RouterService struct { | ||
| handlers map[string]routerHandler | ||
| } | ||
|
|
||
| func NewRouterService() *RouterService { | ||
| return &RouterService{ | ||
| handlers: make(map[string]routerHandler), | ||
| } | ||
| } | ||
|
|
||
| func (rs *RouterService) RegisterHandler(handler routerHandler, typeUrl string) { | ||
| rs.handlers[typeUrl] = handler | ||
| } | ||
|
|
||
| func (rs RouterService) CanInvoke(ctx context.Context, typeUrl string) error { | ||
| if rs.handlers[typeUrl] == nil { | ||
| return fmt.Errorf("no handler for typeURL %s", typeUrl) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (rs RouterService) Invoke(ctx context.Context, req transaction.Msg) (transaction.Msg, error) { | ||
| typeUrl := msgTypeURL(req) | ||
| if rs.handlers[typeUrl] == nil { | ||
| return nil, fmt.Errorf("no handler for typeURL %s", typeUrl) | ||
| } | ||
| return rs.handlers[typeUrl](ctx, req) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would there be any benefits to including the other fields from abci's QueryRequest type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is just mocking the data, and we only use it to marshal the query info these two fields