feat: rate limit module #8268
Open
feat: rate limit module #8268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mconcat
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
10 tasks
Comment on lines
+53
to
+56
| ck, ok := ics4Wrapper.(*channelkeeper.Keeper) | ||
| if ok { | ||
| im.channelKeeper = ck | ||
| } else { |
There was a problem hiding this comment.
Isn't this going to require ICS4Wrapper to be the channelkeeper. THis is wrong, we want ability to wrap ratelimiting with higher level middleware
Comment on lines
+197
to
+206
| packetToCheck := channeltypes.Packet{ | ||
| Sequence: seq, | ||
| SourcePort: sourcePort, | ||
| SourceChannel: sourceChannel, | ||
| TimeoutHeight: timeoutHeight, | ||
| TimeoutTimestamp: timeoutTimestamp, | ||
| Data: data, | ||
| } | ||
|
|
||
| err = im.keeper.SendRateLimitedPacket(ctx, packetToCheck) |
There was a problem hiding this comment.
Seems this can be refactored to not need to construct the packetToCheck
Comment on lines
+217
to
+220
| if actualSeq != seq { | ||
| return 0, errorsmod.Wrapf(channeltypes.ErrInvalidPacket, "sequence mismatch: expected %d, got %d", seq, actualSeq) | ||
| } | ||
|
|
DeshErBojhaa
force-pushed
the
feature/rate-limit
branch
from
641539e to
26cc7cd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8268 +/- ##
===========================================
- Coverage 61.62% 18.27% -43.36%
===========================================
Files 299 28 -271
Lines 21462 2643 -18819
===========================================
- Hits 13227 483 -12744
+ Misses 7643 2132 -5511
+ Partials 592 28 -564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #7974
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.