Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-4203 pass RevSeqNo for on demand imports #7273

Open
wants to merge 11 commits into
base: release/anemone
Choose a base branch
from
Open

CBG-4203 pass RevSeqNo for on demand imports #7273

wants to merge 11 commits into from
+163 −87

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Jan 9, 2025 •
edited
Loading

Pass RevSeqNo for on demand imports, write and get.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Blocked on couchbaselabs/rosmar#43

Integration Tests

@torcolvin torcolvin requested a review from adamcfraser January 9, 2025 01:11
adamcfraser
adamcfraser requested changes Jan 9, 2025
View reviewed changes
db/crud.go Outdated Show resolved Hide resolved
db/crud.go Outdated Show resolved Hide resolved
db/crud.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torcolvin @adamcfraser