Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-4448: updates to fix python lint #7275

Merged
merged 2 commits into from
Jan 9, 2025
Merged

CBG-4448: updates to fix python lint #7275

merged 2 commits into from
Jan 9, 2025

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Jan 9, 2025

CBG-4448

  • ruff updated and changes expected format, this PR will fix any failing python format actions

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

Copy link
Collaborator

@torcolvin torcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the python-format as well? The lint doesn't actually do the format checks for Reasons https://github.com/astral-sh/ruff#usage that I think are that format is supposed to automatically fix, but lint is advisory or the user fixes.

@gregns1 gregns1 merged commit e1da18f into main Jan 9, 2025
38 checks passed
@gregns1 gregns1 deleted the CBG-4448 branch January 9, 2025 16:21
gregns1 added a commit that referenced this pull request Jan 9, 2025
* CBG-4448: updates to fix python lint

* update python format
torcolvin pushed a commit that referenced this pull request Jan 9, 2025
* CBG-4448: updates to fix python lint

* update python format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants