Topology test fixes #7284
Merged
Topology test fixes #7284
+29
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her current mutation already represented in HLV when importing on the target
torcolvin
approved these changes
Jan 11, 2025
| @@ -1242,7 +1242,7 @@ func (db *DatabaseCollectionWithUser) PutExistingCurrentVersion(ctx context.Cont | |||
| } | |||
| } else { | |||
| if doc.HLV.isDominating(newDocHLV) { | |||
| base.DebugfCtx(ctx, base.KeyCRUD, "PutExistingCurrentVersion(%q): No new versions to add", base.UD(newDoc.ID)) | |||
| base.DebugfCtx(ctx, base.KeyCRUD, "PutExistingCurrentVersion(%q): No new versions to add. existing: %#v new:%#v", base.UD(newDoc.ID), doc.HLV, newDocHLV) | |||
There was a problem hiding this comment.
This should possibly be KeyVV to match above
|
|
||
| // wait for push replication to stop running | ||
| require.EventuallyWithT(btc.TB(), func(c *assert.CollectT) { | ||
| require.True(c, btc.pushRunning.IsTrue() == false) |
There was a problem hiding this comment.
Suggested change
| require.True(c, btc.pushRunning.IsTrue() == false) | |
| assert.False(c, btc.pushRunning.IsTrue()) |
the way that assertion is written will actually fail immediately if btc.pushRunning.IsTrue() == true and it won't do a backoff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test logging enhancements:
Flaky test fixes: