Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put new solutions in the proper folder #4246

Merged
merged 5 commits into from
Jan 24, 2024
Merged

put new solutions in the proper folder #4246

merged 5 commits into from
Jan 24, 2024

Conversation

xyzqm
Copy link
Member

@xyzqm xyzqm commented Jan 22, 2024

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@xyzqm
Copy link
Member Author

xyzqm commented Jan 22, 2024

@envyaims this should fix the folder issue for new solutions, would you mind testing it rq once it deploys 🙏🏻

@xyzqm xyzqm enabled auto-merge January 22, 2024 05:00
@xyzqm xyzqm requested a review from envyaims January 22, 2024 05:00
@envyaims
Copy link
Member

for new internal solutions, can you make it also go into contents and change kind from whatever it is to "internal" or is that too much D;

@xyzqm
Copy link
Member Author

xyzqm commented Jan 23, 2024

Isn't this already a feature? When I open cf-468B, the editor automatically opens content/4_Gold/DSU.mdx and updates metadata to internal:
image
Or are you talking about something else?

@envyaims
Copy link
Member

really? it didn't seem like it worked for me when i made the pr (i had to manually do it) 😩

@envyaims
Copy link
Member

if you tested it works then it's probably fine then

@xyzqm
Copy link
Member Author

xyzqm commented Jan 24, 2024

okok would you mind giving an approval bc its needed to merge now 😭

@xyzqm xyzqm merged commit 6fc6633 into master Jan 24, 2024
@xyzqm xyzqm deleted the update_modal branch January 24, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants