Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aliens trick 👽 #4382

Merged
merged 24 commits into from
Mar 23, 2024
Merged

aliens trick 👽 #4382

merged 24 commits into from
Mar 23, 2024

Conversation

A1exL1ang
Copy link
Contributor

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@A1exL1ang A1exL1ang requested a review from dongliuu as a code owner March 13, 2024 23:53
envyaims
envyaims previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@envyaims envyaims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this pr but i love alex even more

envyaims
envyaims previously approved these changes Mar 13, 2024
View reviewed changes
SansPapyrus683
SansPapyrus683 requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool pr

A1exL1ang and others added 2 commits March 15, 2024 20:43
@A1exL1ang
Update Lagrange.mdx
d79e3ea 
Changed code and updated explanation to make everything align with the dp transitions
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3c11658 
for more information, see https://pre-commit.ci
@A1exL1ang
Copy link
Contributor Author

Can someone also check if the explanation is correct lol 😨 💀 :trust:

SansPapyrus683
SansPapyrus683 requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

@A1exL1ang @SansPapyrus683
Update content/6_Advanced/Lagrange.mdx
0765a97 
Co-authored-by: SansPapyrus683 <55369003+SansPapyrus683@users.noreply.github.com>
SansPapyrus683
SansPapyrus683 previously approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there we go
just show a screenshot of this current solution AC-ing and we're good to go

@A1exL1ang
Copy link
Contributor Author

image

wait has anyone reviewed if the geo description is correct lol

@SansPapyrus683
Copy link
Contributor

haha no lol
ping benq if you're feeling up to it

@A1exL1ang
Copy link
Contributor Author

@bqi343 are u willing to check if the explanations are correct

bqi343
bqi343 requested changes Mar 23, 2024
View reviewed changes
Copy link
Member

@bqi343 bqi343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read that carefully but looks correct

A1exL1ang and others added 3 commits March 23, 2024 16:05
@A1exL1ang @bqi343
Update content/6_Advanced/Lagrange.mdx
d8c72d0 
Co-authored-by: Benjamin Qi <bqi343@gmail.com>
@A1exL1ang @bqi343
Update content/6_Advanced/Lagrange.mdx
cdb0e0b 
Co-authored-by: Benjamin Qi <bqi343@gmail.com>
@A1exL1ang
Update Lagrange.mdx
14e06c8
@A1exL1ang
Copy link
Contributor Author

A1exL1ang commented Mar 23, 2024 •
edited
Loading

made a small change to the binary search. everything should be good now :trust:
code AC: https://oj.uz/submission/952444

@SansPapyrus683 SansPapyrus683 merged commit 560ed3e into cpinitiative:master Mar 23, 2024
3 checks passed
@SansPapyrus683
Copy link
Contributor

OOPS forgot to pay you
can you contact @thecodingwizard to figure out payment or whatever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@envyaims envyaims

@bqi343 bqi343

@SansPapyrus683 SansPapyrus683

@dongliuu dongliuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@A1exL1ang @SansPapyrus683 @bqi343 @envyaims