Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bounties] 2SAT content added with some problems #4541

Merged
merged 41 commits into from
Jun 28, 2024
Merged

[Bounties] 2SAT content added with some problems #4541

merged 41 commits into from
Jun 28, 2024

Conversation

Sosuke23
Copy link
Member

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@Sosuke23 Sosuke23 requested a review from dongliuu as a code owner June 22, 2024 18:19
SansPapyrus683
SansPapyrus683 requested changes Jun 23, 2024
View reviewed changes
@Sosuke23 Sosuke23 requested a review from ryanchou-dev as a code owner June 25, 2024 08:49
@Sosuke23
Copy link
Member Author

ignore the today's commit..... just ran into some troubles with git ....

TheGamingMousse
TheGamingMousse approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@TheGamingMousse TheGamingMousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to remove the using vi = vector<int>; and the #define pb push_back for the kosaraju code, but you didn't write that so its fine

ryanchou-dev
ryanchou-dev approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SansPapyrus683 SansPapyrus683 merged commit 15a2481 into cpinitiative:master Jun 28, 2024
3 checks passed
@SansPapyrus683
Copy link
Contributor

no yeah i'll clean up the other parts later

@bqi343 bqi343 mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SansPapyrus683 SansPapyrus683 SansPapyrus683 approved these changes

@TheGamingMousse TheGamingMousse TheGamingMousse approved these changes

@ryanchou-dev ryanchou-dev ryanchou-dev approved these changes

@dongliuu dongliuu Awaiting requested review from dongliuu dongliuu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sosuke23 @SansPapyrus683 @TheGamingMousse @ryanchou-dev