Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editorial] Difference Arrays #4558

Merged
merged 26 commits into from
Jun 30, 2024
Merged

[Editorial] Difference Arrays #4558

merged 26 commits into from
Jun 30, 2024

Conversation

brebenelmihnea
Copy link
Contributor

@brebenelmihnea brebenelmihnea commented Jun 27, 2024 •
edited
Loading

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@brebenelmihnea
Copy link
Contributor Author

https://codeforces.com/contest/295/submission/267648564
image

envyaims
envyaims approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@envyaims envyaims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont like the tuples but ok

ryanchou-dev
ryanchou-dev requested changes Jun 27, 2024
View reviewed changes
@TheGamingMousse
Copy link
Contributor

imo std::array<int, 3> is way cleaner, altho ig it doesn't really matter

@brebenelmihnea
Copy link
Contributor Author

brebenelmihnea commented Jun 27, 2024 •
edited
Loading

Alright i changed tuple to array

@brebenelmihnea
Copy link
Contributor Author

brebenelmihnea commented Jun 28, 2024 •
edited
Loading

Ok i discovered something weird. I didn'y that having 2 identical headers like implementation can cause an error.
Good to know :))

@SansPapyrus683 SansPapyrus683 enabled auto-merge June 29, 2024 11:40
ryanchou-dev
ryanchou-dev approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SansPapyrus683 SansPapyrus683 merged commit 439f749 into cpinitiative:master Jun 30, 2024
3 checks passed
@brebenelmihnea brebenelmihnea deleted the difference-array branch June 30, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheGamingMousse TheGamingMousse TheGamingMousse left review comments

@SansPapyrus683 SansPapyrus683 SansPapyrus683 approved these changes

@envyaims envyaims envyaims approved these changes

@ryanchou-dev ryanchou-dev ryanchou-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brebenelmihnea @TheGamingMousse @SansPapyrus683 @envyaims @ryanchou-dev