Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PIE #5143

Merged
merged 22 commits into from
Mar 9, 2025
Merged

update PIE #5143

merged 22 commits into from
Mar 9, 2025

Conversation

Sosuke23
Copy link
Member

@Sosuke23 Sosuke23 commented Feb 21, 2025

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

closes: #4702

there was a typo and the previous code was wrong for some test cases so I corrected it.
the previous problem link was not working so I changed it to the archive one

@Sosuke23 Sosuke23 requested a review from dongliuu as a code owner February 21, 2025 15:46
@SansPapyrus683
Copy link
Contributor

what was the bug in the previous code?

@Sosuke23
Copy link
Member Author

what was the bug in the previous code?

it was not handling the '?' characters properly

@Sosuke23
Copy link
Member Author

u can check with this test case:

k = 9;
patterns = {"??????????????????????c???????????????????????????","????h??????????r???????????????????r??????????????","????????????????????i??????????????o??????????????","????????????????????????jh????????????????????????","?????????????s??????????????????????????????????u?","?????????e??????c??????????????g??????o????n??????","???????????????????????????ff????????????????????a","?k?????????????o?????????h????????????????????????","?????????w????????????c?????y?????????????????????","??????????????????????????????????v???????d???????","?q????????????????????a??????????????????s??????b?","????????????????ta??????????????????????????j?????","?????????????????????????????v??????????????u?????","y??????????f?????u???a?u??????????????????????????","????????????????????????????????????r?????????????"};

@SansPapyrus683
Copy link
Contributor

wait so that sol literally didn't ac? omg

@Sosuke23
Copy link
Member Author

wait so that sol literally didn't ac? omg

yes

Copy link
Contributor

@TheGamingMousse TheGamingMousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sosuke23 can u send proof of AC? j to make sure

@Sosuke23
Copy link
Member Author

@Sosuke23 can u send proof of AC? j to make sure

how do u submit to past srm contest?
btw I manually tested most of the test cases.

@TheGamingMousse
Copy link
Contributor

@Sosuke23 can u send proof of AC? j to make sure

how do u submit to past srm contest? btw I manually tested most of the test cases.

if u manually tested most TCs its PROBABLY fine, maybe consider finding another sol and stresstesting it

@Sosuke23
Copy link
Member Author

@Sosuke23 can u send proof of AC? j to make sure

how do u submit to past srm contest? btw I manually tested most of the test cases.

if u manually tested most TCs its PROBABLY fine, maybe consider finding another sol and stresstesting it

the previous dp solution is correct so I tested all three solutions together

@Sosuke23
Copy link
Member Author

Sosuke23 commented Mar 3, 2025

@envyaims can you confirm the time complexity of second implementation of set of patterns?

Copy link
Contributor

@TheGamingMousse TheGamingMousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baller

@TheGamingMousse TheGamingMousse merged commit 7b58700 into cpinitiative:master Mar 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Form Submission - Suggestion (Platinum - Inclusion-Exclusion Principle)
3 participants