Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorg Silver sorting and searching modules, move some modules to Gold #5176

Merged
merged 12 commits into from
Mar 6, 2025

Conversation

bqi343
Copy link
Member

@bqi343 bqi343 commented Mar 5, 2025

TODO: read through Silver and Gold sorting / ds sections again to check that ordering of topics makes sense.

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@bqi343 bqi343 changed the title reorg Silver sorting and seraching modules, move some modules to Gold reorg Silver sorting and searching modules, move some modules to Gold Mar 6, 2025
@SansPapyrus683
Copy link
Contributor

most of the problems in the pq module use sets

@bqi343
Copy link
Member Author

bqi343 commented Mar 6, 2025

I am rewriting some of the internal sols to remove the sets (William and Robots, Convention II). There is no reason to use sets here.

I don't think any other internal sols use sets.

@bqi343 bqi343 marked this pull request as ready for review March 6, 2025 00:58
@bqi343 bqi343 requested review from envyaims and dongliuu as code owners March 6, 2025 00:58
@SansPapyrus683
Copy link
Contributor

can i ask for proof of ac?

@bqi343
Copy link
Member Author

bqi343 commented Mar 6, 2025

I have resubmitted all the code I modified.

@bqi343
Copy link
Member Author

bqi343 commented Mar 6, 2025

most of the problems in the pq module use sets

@SansPapyrus683 does it look good now?

@SansPapyrus683
Copy link
Contributor

should difficulty be updated

@bqi343
Copy link
Member Author

bqi343 commented Mar 6, 2025

difficulty of what?

@bqi343
Copy link
Member Author

bqi343 commented Mar 6, 2025

feel free to change them if you want (or not)

Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, i suppose i'll get used to this with time

@bqi343 bqi343 merged commit a8f3889 into master Mar 6, 2025
4 checks passed
@bqi343 bqi343 deleted the silver-sorting-reorg branch March 6, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Form Submission - Suggestion (Silver - More Operations on Sorted Sets)
2 participants