Adding a new module to bronze: Precomputations #5188
Conversation
enplasmatic
requested review from
SansPapyrus683 and
ryanchou-dev
as code owners
There was a problem hiding this comment.
I'm not sure what this module is really about. It feels more like a technique that comes with solving problems than an actual algorithm or type of problems. I think it's super vague on what "precomputation" covers, unlike prefix sums which is much more concrete.
Btw, please check in with us before you write a whole module in the future.
content/2_Bronze/Precomp.mdx
Outdated
| Here are some common examples of precomputation techniques: | ||
| - Finding the frequency of each element in an array beforehand | ||
| - Noting down where each element appears in an array beforehand | ||
| - Performing an operation on each element of an array beforehand |
There was a problem hiding this comment.
what does "performing an operation on an element" mean?
content/2_Bronze/Precomp.mdx
Outdated
| <Spoiler title="Hint"> | ||
|
|
||
|
|
||
| Is there anything we can precompute before we run the main code? |
There was a problem hiding this comment.
how do you categorize the precomputational part of the code vs the main part of the code? I argue that your "precomputation" is an essential part of the main algorithm for solving the problem.
There was a problem hiding this comment.
would you suggest improving / making the module more clear, or scrapping it entirely?
Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.
This module will explain the importance of precomputing values before running main code in a solution (e.g., finding frequency of an element beforehand)