Fixed #16432

craftcms · Jan 15, 2025 · 67d005e · 67d005e
1 parent 01c2875
commit 67d005e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG-WIP.md b/CHANGELOG-WIP.md
@@ -30,4 +30,5 @@
 - Image cleansing now preserves the original image quality, if known.
 - Fixed a bug where `craft\config\GeneralConfig::safeMode()` set Safe Mode to `false` by default.
 - Fixed a bug where Craft wasn’t auto-rotating or flipping images uploaded with a mirrored EXIF orientation.
+- Fixed a bug where elements weren’t getting returned in a consistent order when `orderBy` was set to `RAND(X)` across varying `limit` param values. ([#16432](https://github.com/craftcms/cms/issues/16432))
 - Updated Twig to 3.15. ([#16207](https://github.com/craftcms/cms/discussions/16207))
diff --git a/src/elements/db/ElementQuery.php b/src/elements/db/ElementQuery.php
@@ -3051,7 +3051,8 @@ private function _applyOrderByParams(YiiConnection $db): void
             unset($direction);
         }
 
-        $this->query->orderBy($orderBy);
+        // No need to set orderBy on $this->query. And doing so breaks RAND(X).
+        // (see https://github.com/craftcms/cms/issues/16432)
         $this->subQuery->orderBy($orderBy);
     }