Skip to content

[QE] Set env var windows #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged

[QE] Set env var windows #4624

merged 2 commits into from
May 2, 2025

Conversation

albfan
Copy link
Contributor

@albfan albfan commented Feb 17, 2025

Description

CI sets some configurations using env var, FOO=bar, but windows do not support that format, it should be $env:FOO=bar;

Fixes: #4618

@openshift-ci openshift-ci bot requested review from adrianriobo and gbraad February 17, 2025 12:51
Copy link

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adrianriobo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@albfan albfan requested a review from anjannath February 17, 2025 12:53
@albfan albfan force-pushed the set-env-var-windows branch from 9222f56 to 561d278 Compare February 17, 2025 14:07
@albfan albfan force-pushed the set-env-var-windows branch from 561d278 to f101751 Compare February 17, 2025 14:26
@cfergeau
Copy link
Contributor

Some of the test failures look related to these changes:

 cd tools && GOBIN="/go/src/github.com/crc-org/crc/tools/bin" go install github.com/golangci/golangci-lint/cmd/golangci-lint
"/go/src/github.com/crc-org/crc/tools/bin"/golangci-lint run
test/extended/util/util.go:34:4: S1023: redundant break statement (gosimple)
			break
			^
test/extended/util/util.go:37:4: S1023: redundant break statement (gosimple)
			break
			^ 

@albfan albfan force-pushed the set-env-var-windows branch from f101751 to 7450807 Compare April 24, 2025 14:45
@praveenkumar
Copy link
Member

/go/src/github.com/crc-org/crc/tools/bin"/golangci-lint run
test/extended/util/util.go:34:4: S1023: redundant break statement (gosimple)
			break
			^
test/extended/util/util.go:37:4: S1023: redundant break statement (gosimple)
			break 

linter is failing, make sure run make cross-lint after your changes to make sure it doesn't fail linting side.

@albfan albfan force-pushed the set-env-var-windows branch 2 times, most recently from c742046 to 648d91b Compare May 2, 2025 10:38
Alberto Fanjul added 2 commits May 2, 2025 15:22
Powershell needs bool parameters to be $true or $false
@albfan albfan force-pushed the set-env-var-windows branch from 648d91b to 82afc14 Compare May 2, 2025 13:26
@albfan albfan merged commit 83a4150 into crc-org:main May 2, 2025
19 checks passed
@albfan albfan deleted the set-env-var-windows branch May 2, 2025 13:26
Copy link

openshift-ci bot commented May 2, 2025

@albfan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 82afc14 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QE] integration: Setting env var on windows fail
6 participants