Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of JSON decoding #91

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

cpaillet
Copy link
Contributor

@cpaillet cpaillet commented Jan 9, 2025

If JSON decoding fails, if a field is missing, or if there are no fields, a ConsulException is returned.

@cpaillet cpaillet force-pushed the master branch 7 times, most recently from 56188f1 to c2db69c Compare January 9, 2025 10:29
To avoid too-many-branches in next review.
If JSON decoding fails, if a field is missing, or if there are no fields, a ConsulException is returned.
@cpaillet cpaillet requested a review from a team January 9, 2025 10:44
@cpaillet cpaillet merged commit 3c0413f into criteo:master Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants