Skip to content

Conversation

jkarni
Copy link

@jkarni jkarni commented Jul 16, 2025

Issue reference:
#89

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission? [hlint]
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this? [It is not breaking unless new fields are always considered breaking]

@kvanbere
Copy link
Member

kvanbere commented Jul 19, 2025

Thanks, is there any documentation from GitHub that backs this? Maybe we should link it here for future reference.

@kvanbere
Copy link
Member

@ashercuedo

@ashercuedo
Copy link
Collaborator

Thanks for the pull request, I'll jump on it as soon as I can 👍

@jkarni
Copy link
Author

jkarni commented Jul 22, 2025

Thanks, is there any documentation from GitHub that backs this? Maybe we should link it here for future reference.

The main source is still the push event, which is already referenced in the PushEvent type. It's not referenced directly in HookCommit, but as far as I can tell this is actually a common datatype for several different similar fields in GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants