Skip to content

Conversation

jkarni
Copy link

@jkarni jkarni commented Jul 16, 2025

Issue reference:
#93

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission?
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this?

@kvanbere
Copy link
Member

I don’t know enough about nix to know whether this is okay or not, but one thing that stands out to me is the flake description - maybe it should be changed from the default.

Happy to merge it.

@kvanbere
Copy link
Member

@ashercuedo

@ashercuedo
Copy link
Collaborator

Thanks for the pull request, I'll get onto it as soon as I can 👍

@jkarni
Copy link
Author

jkarni commented Jul 22, 2025

one thing that stands out to me is the flake description - maybe it should be changed from the default.

Good call - changed to something more specific.

@ashercuedo
Copy link
Collaborator

Looking pretty good I reckon. Just curious, I'm not super familiar with .Nix - but is there a reason why the file uses nixpkgs from the unstable branch?

nixpkgs.url = "github:nixos/nixpkgs?ref=nixos-unstable";

Totally cool if that is a common thing to do, just thinking that since this is supposed to be a generic Flake file we might want to change it to the same as the Nix wiki:

nixpkgs.url = "github:NixOS/nixpkgs";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants