misc: Update nested groups design #31739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
alejandro/feat/update-nested-groups-styles
|
| Run status |
|
| Run duration | 18m 26s |
| Commit |
|
| Committer | Alejandro Estrada |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32181
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.56%
|
|
|---|---|
|
Untested elements
|
191
|
|
Tested elements
|
164
|
Accessibility
92.73%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
695
|
|
@estrada9166 Awaiting clarity from this discussion on the movement of all commands spacing: https://cypressio.slack.com/archives/C3WD9SGKW/p1747770478568459?thread_ts=1747430139.407099&cid=C3WD9SGKW |
…dated the CommandDetails component to conditionally apply a class for child commands and added corresponding SCSS styles to display a prefix for child command methods.
…ion for better readability.
…layout control and adjusting margin for command number column.
…mmand info padding. Update error component styles for improved layout and consistency. Adjust padding and margins for better alignment across command and error sections.
…dating group indentation styles into a mixin. Update SCSS files to utilize the new mixin for consistent width handling across command and error components.
… consistency in command info and group indentation styles.
… and add logging and expectation in Cypress test for improved clarity in UI state tests.
…panel size, improving snapshot accuracy and visibility of UI elements.
…enhancing UI element visibility and accuracy.
jennifer-shehane
approved these changes
May 28, 2025
| @@ -465,20 +477,14 @@ | |||
| } | |||
| } | |||
|
|
|||
| .command-expander-column { | |||
| %command-expander-base { | |||
There was a problem hiding this comment.
TIL something new in Sass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Update the nested groups design so that it can show the caret next to the tile and not next to the first dotted line.
Figma
before:
after:
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?