chore: convert cypress.spec.ts, errors.spec.ts and logger.spec.ts to vitest.
#32424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
changed the title
cypress.spec.ts, errors.spec.ts and logger.spec.ts to vitest.
AtofStryker
force-pushed
the
chore/misc_tests_cli
branch
from
abbd8a5 to
a6e43d8
Compare
AtofStryker
force-pushed
the
chore/convert-utils-vitest
branch
from
e85596d to
d666571
Compare
AtofStryker
force-pushed
the
chore/misc_tests_cli
branch
from
a6e43d8 to
44619db
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AtofStryker
force-pushed
the
chore/misc_tests_cli
branch
from
44619db to
1c70b7f
Compare
cypress
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/misc_tests_cli
|
| Run status |
|
| Run duration | 43m 50s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
3
|
Flaky
|
9
|
Pending
|
1102
|
Skipped
|
0
|
Passing
|
26518
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
43.87%
|
|
|---|---|
|
Untested elements
|
178
|
|
Tested elements
|
143
|
Accessibility
97.7%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
110
|
Tests for review
src/gql-components/modals/SelectCloudProjectModal.cy.tsx • 1 failed test • frontend-shared-ct
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
|
|
cypress/e2e/error-handling.cy.ts • 2 failed tests • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| ... > automatically sources vite.config.js |
Test Replay
Screenshots
|
|
| ... > automatically sources webpack.config.js |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an xhr request is canceled |
The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud. | |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
gonna move this to draft |
AtofStryker
force-pushed
the
chore/misc_tests_cli
branch
from
1c70b7f to
03261a0
Compare
AtofStryker
force-pushed
the
chore/convert-utils-vitest
branch
from
d666571 to
ebe3286
Compare
AtofStryker
force-pushed
the
chore/misc_tests_cli
branch
from
03261a0 to
c30288b
Compare
AtofStryker
force-pushed
the
chore/misc_tests_cli
branch
from
c30288b to
ea18b2d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cacieprins
approved these changes
Sep 5, 2025
| import util from './util' | ||
| import state from './tasks/state' | ||
|
|
||
| // TODO: this package needs to be replaced as we can't import it in vitest | ||
| const is = require('check-more-types') |
There was a problem hiding this comment.
Just remove it :D all of these assertions are simple to just have inline.
There was a problem hiding this comment.
after the vitest conversion is done I am planning on doing this. This can be made a lot simpler
Base automatically changed from
chore/convert-utils-vitest
to
feature/cli_to_vitest
September 5, 2025 16:36
AtofStryker
force-pushed
the
chore/misc_tests_cli
branch
from
94c94f8 to
046588d
Compare
AtofStryker
force-pushed
the
chore/misc_tests_cli
branch
from
046588d to
0dd146f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
converts the
cypress.spec.ts,errors.spec.tsandlogger.spec.tsto vitest. Also refactors the source code to make it easier to unit testSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?