Skip to content

Conversation

AtofStryker
Copy link
Contributor

  • Closes

Additional details

Converts the exec directory to vitest. Some of the source files in the directory have also been reworked to make them easier to test

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker marked this pull request as ready for review September 4, 2025 14:49
cursor[bot]

This comment was marked as outdated.

@AtofStryker AtofStryker marked this pull request as draft September 4, 2025 15:40
@AtofStryker
Copy link
Contributor Author

going to move this to draft

@AtofStryker AtofStryker force-pushed the chore/misc_tests_cli branch 3 times, most recently from c30288b to ea18b2d Compare September 4, 2025 16:22
@AtofStryker AtofStryker marked this pull request as ready for review September 4, 2025 17:41
cursor[bot]

This comment was marked as outdated.

@AtofStryker AtofStryker marked this pull request as draft September 4, 2025 19:52
@AtofStryker AtofStryker self-assigned this Sep 4, 2025
@AtofStryker AtofStryker marked this pull request as ready for review September 4, 2025 20:25
cursor[bot]

This comment was marked as outdated.

@AtofStryker AtofStryker force-pushed the chore/cli_tests_exec branch 2 times, most recently from cdbf532 to 758e743 Compare September 4, 2025 20:47
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

cypress bot commented Sep 4, 2025

cypress    Run #65318

Run Properties:  status check passed Passed #65318  •  git commit 6058435507: chore: cut over exec directory to vitest
Project cypress
Branch Review chore/cli_tests_exec
Run status status check passed Passed #65318
Run duration 19m 54s
Commit git commit 6058435507: chore: cut over exec directory to vitest
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 11
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26661
View all changes introduced in this branch ↗︎
UI Coverage  44.86%
  Untested elements 188  
  Tested elements 157  
Accessibility  97.72%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 110  

cursor[bot]

This comment was marked as outdated.

@AtofStryker AtofStryker force-pushed the chore/cli_tests_exec branch 2 times, most recently from b5689a8 to 6430456 Compare September 5, 2025 01:33
cursor[bot]

This comment was marked as outdated.

Base automatically changed from chore/misc_tests_cli to feature/cli_to_vitest September 5, 2025 17:42
@AtofStryker AtofStryker merged commit 93e883e into feature/cli_to_vitest Sep 5, 2025
3 of 5 checks passed
@AtofStryker AtofStryker deleted the chore/cli_tests_exec branch September 5, 2025 19:09
AtofStryker added a commit that referenced this pull request Sep 12, 2025
* chore: rename snapshots and spec files to fit vitest convention (#32405)

* chore: move compiled files to dist directory to make vitest convertion easier (#32406)

* chore: convert utils to vitest (#32407)

* chore: convert logger to vitest

* chore: convert errors spec to vitest

* chore: convert cypress spec to vitest

* chore: convert `exec` directory to `vitest` (#32428)

* chore: cut over exec directory to vitest

* Update cli/test/lib/exec/run.spec.ts

* Update cli/test/lib/exec/run.spec.ts

* Update cli/test/lib/exec/run.spec.ts

* chore: convert the CLI and build script specs over to vitest (#32438)

* chore: convert tasks directory to vitest (#32434)

change way verify module is exported due to issues interpreting module (thinks its an esm)

rework scripts as we cannot run an empty mocha suite

chore: fix snapshots and verify requires that are internal to the cypress project

fix stubbing issues with fs-extra which is also used by request-progress under the hood

fix issues where xvfb was stopping prematurely

* chore: remove files no longer used now that mocha tests are converted to vitest (#32455)

* build binaries

* chore: fix CLI tests (#32484)

* chore: remove CI branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants