Use tuple for MultiscalarMul
#792
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiscalarMul
currently takes two iterators for scalars and points respectively. This has the downside that if they are differently sized we currently simply panic.This PR changes that by putting them both into one iterator with
Item = (Point, Scalar)
. This way we get rid of the panic and don't loose any of the flexibility.Migration for users should be quite straightforward, just add a
zip()
between the two parameters, as shown in the example.I also switched the order of scalars and points around to align more with
elliptic_curve::LinearCombination
and applied the same tuple-treatment to the fixed-sized array method as well. This does affect its flexibility and maybe we should changeelliptic_curve::LinearCombination
accordingly.As requested in #790.