-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "/server-info/" frontend endpoint in development builds #1190
Conversation
762bdf3
to
5a94447
Compare
I think a better solution would be to proxy |
I agree, and I'll file an issue to make this the standard way the API is proxied through to the front end, but if we can merge this PR, it will provide the CLI team immediate value, and then we can get to the fuller solution afterwards. |
confirming that it works as intended:
(whenever on master it gives html page about JS needed etc). |
🚀 PR was released in |
This PR adds an "endpoint" to the frontend that proxies to the backend server info endpoint, emulating the mechanism in place on the Netlify-controlled deploys.
This works but only if you ask for the path complete with trailing slash, and I'm not sure why. Reviewers, perhaps you can recommend a better way to make this work so that the trailing slash is not required.
Closes #1108.