Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meriones unguiculatus to species list #1546

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Add Meriones unguiculatus to species list #1546

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d59e778
Add Meriones unguiculatus to species list
kabilar Nov 29, 2024
a8a5a94
Lower case matches
yarikoptic Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dandi/metadata/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,12 @@ def extract_cellLine(metadata: dict) -> str | None:
NCBITAXON_URI_TEMPLATE.format("9545"),
"Macaca nemestrina",
),
(
["Mongolian gerbil", "Mongolian jird"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be lowercase.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
["Mongolian gerbil", "Mongolian jird"],
["mongolian gerbil", "mongolian jird"],

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally IMHO we should make code robust to specification here and just .lower() then when matching. Or do you see an issue with that @jwodder ?

None,
NCBITAXON_URI_TEMPLATE.format("10047"),
"Meriones unguiculatus",
),
]


Expand Down
Loading