enh: log exception info (at debug) when we catch an exception in map_to_click handler #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to_click handler
User reported a crash where logs where pretty much useless as on the
source/reason for exception:
...
2024-12-11T18:28:38-0500 [DEBUG ] dandi 1351865:139891496982272 sub-I48/ses-SPIM/micr/sub-I48_ses-SPIM_sample-BrocaAreaS01_stain-Calretinin_SPIM.ome.zarr/0/1/51/24 - verified that has correct md5 c805c4f34e250a813f2325741faceddc
2024-12-11T18:28:38-0500 [DEBUG ] dandi 1351865:139894578401792 Caught exception
May be with traceback logged we get more of useful information
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
- Coverage 88.49% 88.48% -0.01%
==========================================
Files 78 78
Lines 10742 10742
==========================================
- Hits 9506 9505 -1
- Misses 1236 1237 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jwodder
approved these changes
Dec 13, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kevancic reported a crash where logs where pretty much useless as on the source/reason for exception:
May be with traceback logged we get more of useful information